From 57e6cd2e497d37d06b4062814ee4def6086443f2 Mon Sep 17 00:00:00 2001
From: Master Kwoth <srki0509@gmail.com>
Date: Sun, 28 Feb 2016 18:59:50 +0100
Subject: [PATCH] free ffmpeg process

---
 NadekoBot/Classes/Music/Song.cs | 52 ++++++++++++++++++++-------------
 1 file changed, 31 insertions(+), 21 deletions(-)

diff --git a/NadekoBot/Classes/Music/Song.cs b/NadekoBot/Classes/Music/Song.cs
index bc595d44..5e5172d2 100644
--- a/NadekoBot/Classes/Music/Song.cs
+++ b/NadekoBot/Classes/Music/Song.cs
@@ -135,28 +135,37 @@ namespace NadekoBot.Classes.Music {
 
         private Task BufferSong(CancellationToken cancelToken) =>
             Task.Run(async () => {
-                var p = Process.Start(new ProcessStartInfo {
-                    FileName = "ffmpeg",
-                    Arguments = $"-i {SongInfo.Uri} -f s16le -ar 48000 -ac 2 pipe:1 -loglevel quiet",
-                    UseShellExecute = false,
-                    RedirectStandardOutput = true,
-                });
-
-                int blockSize = 3840;
-                byte[] buffer = new byte[blockSize];
-                int attempt = 0;
-                while (!cancelToken.IsCancellationRequested) {
-                    int read = await p.StandardOutput.BaseStream.ReadAsync(buffer, 0, blockSize);
-                    if (read == 0)
-                        if (attempt++ == 20)
-                            break;
+                Process p = null;
+                try {
+                    p = Process.Start(new ProcessStartInfo {
+                        FileName = "ffmpeg",
+                        Arguments = $"-i {SongInfo.Uri} -f s16le -ar 48000 -ac 2 pipe:1 -loglevel quiet",
+                        UseShellExecute = false,
+                        RedirectStandardOutput = true,
+                    });
+                    int blockSize = 3840;
+                    byte[] buffer = new byte[blockSize];
+                    int attempt = 0;
+                    while (!cancelToken.IsCancellationRequested) {
+                        int read = await p.StandardOutput.BaseStream.ReadAsync(buffer, 0, blockSize);
+                        if (read == 0)
+                            if (attempt++ == 20)
+                                break;
+                            else
+                                await Task.Delay(50);
                         else
-                            await Task.Delay(50);
-                    else
-                        attempt = 0;
-                    await songBuffer.WriteAsync(buffer, read, cancelToken);
-                    if (songBuffer.ContentLength > 2.MB())
-                        prebufferingComplete = true;
+                            attempt = 0;
+                        await songBuffer.WriteAsync(buffer, read, cancelToken);
+                        if (songBuffer.ContentLength > 2.MB())
+                            prebufferingComplete = true;
+                    }
+                }
+                finally {
+                    if (p != null) {
+                        p.CancelOutputRead();
+                        p.Close();
+                        p.Dispose();
+                    }
                 }
                 Console.WriteLine($"Buffering done. [{songBuffer.ContentLength}]");
             });
@@ -169,6 +178,7 @@ namespace NadekoBot.Classes.Music {
             while (!prebufferingComplete && bufferAttempts++ < toAttemptTimes) {
                 await Task.Delay(waitPerAttempt);
             }
+            Console.WriteLine($"Prebuffering done? in {waitPerAttempt*bufferAttempts}");
             int blockSize = 3840;
             byte[] buffer = new byte[blockSize];
             int attempt = 0;